Skip to content

implement std::fs::set_permissions_nofollow on unix #142938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

implement std::fs::set_permissions_nofollow on unix #142938

wants to merge 1 commit into from
+30 −0

Conversation

lolbinarycat
Copy link
Contributor

implementation of #141607

@rustbot
Copy link
Collaborator

rustbot commented Jun 24, 2025

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 24, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@lolbinarycat lolbinarycat force-pushed the std-set_permissions_nofollow branch from 3ff03e0 to 4614625 Compare June 24, 2025 21:44
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@lolbinarycat lolbinarycat force-pushed the std-set_permissions_nofollow branch from 4614625 to 7d69442 Compare June 25, 2025 18:32
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@lolbinarycat lolbinarycat force-pushed the std-set_permissions_nofollow branch from 7d69442 to 949ac68 Compare June 26, 2025 17:28
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@lolbinarycat lolbinarycat force-pushed the std-set_permissions_nofollow branch from 949ac68 to 8f23f36 Compare June 26, 2025 17:57
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@lolbinarycat lolbinarycat force-pushed the std-set_permissions_nofollow branch from 8f23f36 to 369acf8 Compare June 26, 2025 19:27
@rust-log-analyzer
Copy link
Collaborator

The job mingw-check-2 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
 Documenting std v0.0.0 (/checkout/library/std)
error: unresolved link to `io::FilesystemLoop`
    --> library/std/src/fs.rs:3139:44
     |
3139 | /// On unix platforms, this results in a [`io::FilesystemLoop`] error if the last element is a symlink.
     |                                            ^^^^^^^^^^^^^^^^^^ no item named `FilesystemLoop` in module `io`
     |
     = note: `-D rustdoc::broken-intra-doc-links` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(rustdoc::broken_intra_doc_links)]`

error: could not document `std`
warning: build failed, waiting for other jobs to finish...
[RUSTC-TIMING] std test:false 8.027
Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:01:03
  local time: Thu Jun 26 20:07:07 UTC 2025
  network time: Thu, 26 Jun 2025 20:07:07 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ibraheemdev ibraheemdev

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lolbinarycat @rustbot @rust-log-analyzer @ibraheemdev